[Emacs-diffs] /srv/bzr/emacs/emacs-23 r100178: * lisp/minibuffer.el (minibuffer-completion-help): Specify the end of the

[Stefan Monnier]

------------------------------------------------------------
revno: 100178
committer: Stefan Monnier <address@hidden>
branch nick: emacs-23
timestamp: Mon 2010-11-08 15:53:42 -0500
message:
  * lisp/minibuffer.el (minibuffer-completion-help): Specify the end of the
  completion field.
modified:
  lisp/ChangeLog
  lisp/minibuffer.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-11-08 18:56:10 +0000
+++ b/lisp/ChangeLog    2010-11-08 20:53:42 +0000
@@ -1,5 +1,8 @@
 2010-11-08  Stefan Monnier  <address@hidden>
 
+       * minibuffer.el (minibuffer-completion-help): Specify the end of the
+       completion field (bug#7211).
+
        * progmodes/python.el (python-font-lock-syntactic-keywords): (bug#7322)
        Fix handling of backslash escapes.
        (python-quote-syntax): Adjust accordingly.

=== modified file 'lisp/minibuffer.el'
--- a/lisp/minibuffer.el        2010-10-17 17:30:22 +0000
+++ b/lisp/minibuffer.el        2010-11-08 20:53:42 +0000
@@ -41,7 +41,7 @@
 ;;   provide the start info but not the end info in
 ;;   completion-base-position.
 ;; - quoting is problematic.  E.g. the double-dollar quoting used in
-;;   substitie-in-file-name (and hence read-file-name-internal) bumps
+;;   substitute-in-file-name (and hence read-file-name-internal) bumps
 ;;   into various bugs:
 ;; - choose-completion doesn't know how to quote the text it inserts.
 ;;   E.g. it fails to double the dollars in file-name completion, or
@@ -1075,6 +1075,7 @@
   (interactive)
   (message "Making completion list...")
   (lexical-let* ((start (field-beginning))
+                 (end (field-end))
                 (string (field-string))
                 (completions (completion-all-completions
                               string
@@ -1106,10 +1107,12 @@
                             completions)))
             (with-current-buffer standard-output
               (set (make-local-variable 'completion-base-position)
-                   ;; FIXME: We should provide the END part as well, but
-                   ;; currently completion-all-completions does not give
-                   ;; us the necessary information.
-                   (list (+ start base-size) nil)))
+                   (list (+ start base-size)
+                         ;; FIXME: We should pay attention to completion
+                         ;; boundaries here, but currently
+                         ;; completion-all-completions does not give us the
+                         ;; necessary information.
+                         end)))
             (display-completion-list completions)))
 
       ;; If there are no completions, or if the current input is already the