[Emacs-diffs] emacs/lisp/emacs-lisp checkdoc.el

[Kevin Ryde]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Kevin Ryde <kryde>      09/11/24 23:13:09

Modified files:
        lisp/emacs-lisp: checkdoc.el 

Log message:
        * emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Build
        value with regexp-opt instead of explicit joining loop.  (My
        Bug#4927.)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/emacs-lisp/checkdoc.el?cvsroot=emacs&r1=1.80&r2=1.81

Patches:
Index: checkdoc.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/checkdoc.el,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -b -r1.80 -r1.81
--- checkdoc.el 8 Nov 2009 21:48:43 -0000       1.80
+++ checkdoc.el 24 Nov 2009 23:13:09 -0000      1.81
@@ -334,12 +334,9 @@
   ;; "[.!?]" is for noun at end of a sentence, since those chars
   ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
   ;; The \" allows it to be the last sentence in a docstring too.
-  (let ((expr "\\_<\\(")
-       (l checkdoc-proper-noun-list))
-    (while l
-      (setq expr (concat expr (car l) (if (cdr l) "\\|" ""))
-           l (cdr l)))
-    (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)"))
+  (concat "\\_<"
+         (regexp-opt checkdoc-proper-noun-list t)
+         "\\(\\_>\\|[.!?][ \t\n\"]\\)")
   "Regular expression derived from `checkdoc-proper-noun-regexp'.")
 
 (defvar checkdoc-common-verbs-regexp nil