[Emacs-diffs] emacs/lisp ChangeLog dired.el files.el menu-bar...

[Juanma Barranquero]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Changes by:     Juanma Barranquero <lektu>      09/09/25 04:35:18

Modified files:
        lisp           : ChangeLog dired.el files.el menu-bar.el 
                         pcvs-util.el pcvs.el shell.el vc-dir.el 

Log message:
        * menu-bar.el (list-buffers-directory): Add docstring.
          Make automatically buffer-local.
        
        * dired.el (dired-mode):
        * files.el (cd-absolute):
        * pcvs.el (cvs-temp-buffer):
        * pcvs-util.el (cvs-get-buffer-create):
        * shell.el (shell-mode):
        * vc-dir.el (vc-dir-mode):
          Don't make `list-buffers-directory' buffer local.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.16260&r2=1.16261
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/dired.el?cvsroot=emacs&r1=1.430&r2=1.431
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/files.el?cvsroot=emacs&r1=1.1084&r2=1.1085
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/menu-bar.el?cvsroot=emacs&r1=1.356&r2=1.357
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/pcvs-util.el?cvsroot=emacs&r1=1.41&r2=1.42
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/pcvs.el?cvsroot=emacs&r1=1.123&r2=1.124
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/shell.el?cvsroot=emacs&r1=1.166&r2=1.167
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/vc-dir.el?cvsroot=emacs&r1=1.42&r2=1.43

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.16260
retrieving revision 1.16261
diff -u -b -r1.16260 -r1.16261
--- ChangeLog   25 Sep 2009 03:42:22 -0000      1.16260
+++ ChangeLog   25 Sep 2009 04:35:14 -0000      1.16261
@@ -1,3 +1,16 @@
+2009-09-25  Juanma Barranquero  <address@hidden>
+
+       * menu-bar.el (list-buffers-directory): Add docstring.
+       Make automatically buffer-local.
+
+       * dired.el (dired-mode):
+       * files.el (cd-absolute):
+       * pcvs.el (cvs-temp-buffer):
+       * pcvs-util.el (cvs-get-buffer-create):
+       * shell.el (shell-mode):
+       * vc-dir.el (vc-dir-mode):
+       Don't make `list-buffers-directory' buffer local.
+
 2009-09-25  Devon Sean McCullough  <address@hidden>
 
        * comint.el (comint-exec, comint-run, make-comint): Doc

Index: dired.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dired.el,v
retrieving revision 1.430
retrieving revision 1.431
diff -u -b -r1.430 -r1.431
--- dired.el    24 Sep 2009 01:37:17 -0000      1.430
+++ dired.el    25 Sep 2009 04:35:17 -0000      1.431
@@ -1750,7 +1750,7 @@
   (set (make-local-variable 'dired-directory)
        (or dirname default-directory))
   ;; list-buffers uses this to display the dir being edited in this buffer.
-  (set (make-local-variable 'list-buffers-directory)
+  (setq list-buffers-directory
        (expand-file-name (if (listp dired-directory)
                             (car dired-directory)
                           dired-directory)))

Index: files.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/files.el,v
retrieving revision 1.1084
retrieving revision 1.1085
diff -u -b -r1.1084 -r1.1085
--- files.el    24 Sep 2009 23:22:20 -0000      1.1084
+++ files.el    25 Sep 2009 04:35:17 -0000      1.1085
@@ -656,7 +656,7 @@
     (unless (file-executable-p dir)
       (error "Cannot cd to %s:  Permission denied" dir))
     (setq default-directory dir)
-    (set (make-local-variable 'list-buffers-directory) dir)))
+    (setq list-buffers-directory dir)))
 
 (defun cd (dir)
   "Make DIR become the current buffer's default directory.

Index: menu-bar.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/menu-bar.el,v
retrieving revision 1.356
retrieving revision 1.357
diff -u -b -r1.356 -r1.357
--- menu-bar.el 17 Sep 2009 10:31:06 -0000      1.356
+++ menu-bar.el 25 Sep 2009 04:35:18 -0000      1.357
@@ -1687,7 +1687,10 @@
   :type 'boolean
   :group 'menu)
 
-(defvar list-buffers-directory nil)
+(defvar list-buffers-directory nil
+  "String to display in buffer listings for buffers not visiting a file.
+Dired, shell and other modes use this variable.")
+(make-variable-buffer-local 'list-buffers-directory)
 
 (defun menu-bar-select-buffer ()
   (interactive)

Index: pcvs-util.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs-util.el,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -b -r1.41 -r1.42
--- pcvs-util.el        5 Jan 2009 03:19:39 -0000       1.41
+++ pcvs-util.el        25 Sep 2009 04:35:18 -0000      1.42
@@ -135,7 +135,7 @@
            (when (equal name list-buffers-directory)
              (return buf)))))
       (with-current-buffer (create-file-buffer name)
-       (set (make-local-variable 'list-buffers-directory) name)
+       (setq list-buffers-directory name)
        (current-buffer))))
 
 ;;;;

Index: pcvs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs.el,v
retrieving revision 1.123
retrieving revision 1.124
diff -u -b -r1.123 -r1.124
--- pcvs.el     10 Sep 2009 06:23:10 -0000      1.123
+++ pcvs.el     25 Sep 2009 04:35:18 -0000      1.124
@@ -399,7 +399,7 @@
       ;;(cvs-minor-mode 1)
       (let ((lbd list-buffers-directory))
        (if (fboundp mode) (funcall mode) (fundamental-mode))
-       (when lbd (set (make-local-variable 'list-buffers-directory) lbd)))
+       (when lbd (setq list-buffers-directory lbd)))
       (cvs-minor-mode 1)
       ;;(set (make-local-variable 'cvs-buffer) cvs-buf)
       (if normal

Index: shell.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/shell.el,v
retrieving revision 1.166
retrieving revision 1.167
diff -u -b -r1.166 -r1.167
--- shell.el    24 Sep 2009 01:37:18 -0000      1.166
+++ shell.el    25 Sep 2009 04:35:18 -0000      1.167
@@ -440,10 +440,9 @@
   (make-local-variable 'shell-last-dir)
   (setq shell-last-dir nil)
   (setq comint-input-autoexpand shell-input-autoexpand)
+  (shell-dirtrack-mode 1)
   ;; This is not really correct, since the shell buffer does not really
   ;; edit this directory.  But it is useful in the buffer list and menus.
-  (make-local-variable 'list-buffers-directory)
-  (shell-dirtrack-mode 1)
   (setq list-buffers-directory (expand-file-name default-directory))
   ;; shell-dependent assignments.
   (when (ring-empty-p comint-input-ring)

Index: vc-dir.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc-dir.el,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -b -r1.42 -r1.43
--- vc-dir.el   27 Aug 2009 07:25:46 -0000      1.42
+++ vc-dir.el   25 Sep 2009 04:35:18 -0000      1.43
@@ -928,8 +928,7 @@
     (set (make-local-variable 'vc-ewoc) (ewoc-create #'vc-dir-printer))
     (set (make-local-variable 'revert-buffer-function)
         'vc-dir-revert-buffer-function)
-    (set (make-local-variable 'list-buffers-directory)
-         (expand-file-name default-directory))
+    (setq list-buffers-directory (expand-file-name default-directory))
     (add-hook 'after-save-hook 'vc-dir-resynch-file)
     ;; Make sure that if the directory buffer is killed, the update
     ;; process running in the background is also killed.