[Emacs-diffs] emacs/lisp ChangeLog vc.el

[Dan Nicolaescu]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Changes by:     Dan Nicolaescu <dann>   09/07/23 05:21:37

Modified files:
        lisp           : ChangeLog vc.el 

Log message:
        (vc-print-log-internal): New function, split out from ...
        (vc-print-log): ... here.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15850&r2=1.15851
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/vc.el?cvsroot=emacs&r1=1.720&r2=1.721

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15850
retrieving revision 1.15851
diff -u -b -r1.15850 -r1.15851
--- ChangeLog   23 Jul 2009 05:17:27 -0000      1.15850
+++ ChangeLog   23 Jul 2009 05:21:34 -0000      1.15851
@@ -1,5 +1,8 @@
 2009-07-22  Dan Nicolaescu  <address@hidden>
 
+       * vc.el (vc-print-log-internal): New function, split out from ...
+       (vc-print-log): ... here.
+
        * vc-git.el (vc-git-add-signoff): New variable.
        (vc-git-checkin): Use it.
        (vc-git-toggle-signoff): New function.

Index: vc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
retrieving revision 1.720
retrieving revision 1.721
diff -u -b -r1.720 -r1.721
--- vc.el       26 Jun 2009 23:54:00 -0000      1.720
+++ vc.el       23 Jul 2009 05:21:36 -0000      1.721
@@ -1815,15 +1815,7 @@
 
 ;; Miscellaneous other entry points
 
-;;;###autoload
-(defun vc-print-log (&optional working-revision)
-  "List the change log of the current fileset in a window.
-If WORKING-REVISION is non-nil, leave the point at that revision."
-  (interactive)
-  (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
-        (backend (car vc-fileset))
-        (files (cadr vc-fileset))
-        (working-revision (or working-revision (vc-working-revision (car 
files)))))
+(defun vc-print-log-internal (backend files working-revision)
     ;; Don't switch to the output buffer before running the command,
     ;; so that any buffer-local settings in the vc-controlled
     ;; buffer can be accessed by the command.
@@ -1834,18 +1826,34 @@
        (vc-call-backend ',backend 'log-view-mode)
        (set (make-local-variable 'log-view-vc-backend) ',backend)
        (set (make-local-variable 'log-view-vc-fileset) ',files)
-       (goto-char (point-max)) (forward-line -1)
+      
+      ;; FIXME: this seems to apply only to RCS/CVS, it doesn't quite
+      ;; belong here in the generic code.
+      (goto-char (point-max))
+      (forward-line -1)
        (while (looking-at "=*\n")
          (delete-char (- (match-end 0) (match-beginning 0)))
          (forward-line -1))
        (goto-char (point-min))
        (when (looking-at "[\b\t\n\v\f\r ]+")
          (delete-char (- (match-end 0) (match-beginning 0))))
+
        (shrink-window-if-larger-than-buffer)
        ;; move point to the log entry for the working revision
        (vc-call-backend ',backend 'show-log-entry ',working-revision)
         (setq vc-sentinel-movepoint (point))
-        (set-buffer-modified-p nil)))))
+      (set-buffer-modified-p nil))))
+
+;;;###autoload
+(defun vc-print-log (&optional working-revision)
+  "List the change log of the current fileset in a window.
+If WORKING-REVISION is non-nil, leave the point at that revision."
+  (interactive)
+  (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
+        (backend (car vc-fileset))
+        (files (cadr vc-fileset))
+        (working-revision (or working-revision (vc-working-revision (car 
files)))))
+    (vc-print-log-internal backend files working-revision)))
 
 ;;;###autoload
 (defun vc-revert ()