[Emacs-diffs] emacs/lisp ChangeLog help-fns.el

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       09/07/23 02:55:37

Modified files:
        lisp           : ChangeLog help-fns.el 

Log message:
        (describe-variable): Describe ignored and risky local
        variables in a similar way to that in which we describe safe ones.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15848&r2=1.15849
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/help-fns.el?cvsroot=emacs&r1=1.134&r2=1.135

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15848
retrieving revision 1.15849
diff -u -b -r1.15848 -r1.15849
--- ChangeLog   22 Jul 2009 03:07:18 -0000      1.15848
+++ ChangeLog   23 Jul 2009 02:55:34 -0000      1.15849
@@ -1,3 +1,53 @@
+2009-07-23  Glenn Morris  <address@hidden>
+
+       * help-fns.el (describe-variable): Describe ignored and risky local
+       variables in a similar way to that in which we describe safe ones.
+
+       * emacs-lisp/bytecomp.el (byte-compile-from-buffer)
+       (byte-compile-output-file-form, byte-compile-output-docform)
+       (byte-compile-file-form-defmumble, byte-compile-output-as-comment):
+       Give some more local variables with common names a "bytecomp-" prefix,
+       so as not to shadow things during compilation.
+       * emacs-lisp/cl-macs.el (load-time-value)
+       * emacs-lisp/cl.el (cl-compiling-file): Update for the name-change
+       `outbuffer' to `bytecomp-outbuffer'.
+
+       * emacs-lisp/elint.el (elint-standard-variables): Remove most members,
+       since the next two variables cover them automatically now.
+       (elint-builtin-variables, elint-autoloaded-variables): New.
+       (elint-unknown-builtin-args): Remove all members, since they can be
+       parsed automatically now.
+       (elint-extra-errors): New.
+       (elint-env-add-env, elint-env-add-macro): Use cadr.
+       (elint-current-buffer): Use or.  Change final message.
+       (elint-get-top-forms): Use line-end-position.
+       (elint-init-env): Use cadr.  Handle autoload, declare-function,
+       and defalias.
+       (elint-add-required-env): Doc fix.  Use or.  Standardize error.
+       (regexp-assoc): Remove unused function.
+       (elint-top-form): Set elint-current-pos, to record the start of the
+       top-level form, for compilation-mode.
+       (elint-form): Trap errors in macro expansion.  Use dolist.
+       (elint-unbound-variable): Use elint-builtin-variables and
+       elint-autoloaded-variables.
+       (elint-get-args): Use cadr, or.
+       (elint-check-cond-form): Use dolist, cadr.
+       (elint-check-condition-case-form): Doc fix.  Use cadr.
+       Use elint-extra-errors.
+       (elint-log): New function.
+       (elint-error, elint-warning): Use elint-log for a bytecomp-style format.
+       Distinguish errors and warnings.
+       (elint-log-message): Use with-current-buffer.  Inhibit read-only.
+       Use a bytecomp-style format.
+       (elint-clear-log): Preserve default-directory.  Inhibit read-only.
+       (elint-get-log-buffer): Use compilation mode.  Disable undo.
+       Don't truncate lines.
+       (elint-initialize): Set builtin and autoloaded variable lists.
+       Only process elint-unknown-builtin-args if non-nil.
+       (elint-find-builtin-variables, elint-find-autoloaded-variables):
+       New functions.
+       (elint-find-builtin-args): Doc fix.  Handle "BODY...)".
+
 2009-07-22  Kevin Ryde  <address@hidden>
 
        * net/newst-backend.el (newsticker--parse-atom-1.0)

Index: help-fns.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/help-fns.el,v
retrieving revision 1.134
retrieving revision 1.135
diff -u -b -r1.134 -r1.135
--- help-fns.el 19 Jul 2009 16:56:05 -0000      1.134
+++ help-fns.el 23 Jul 2009 02:55:37 -0000      1.135
@@ -1,7 +1,8 @@
 ;;; help-fns.el --- Complex help functions
 
 ;; Copyright (C) 1985, 1986, 1993, 1994, 1998, 1999, 2000, 2001,
-;;   2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, 
Inc.
+;;   2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009
+;;   Free Software Foundation, Inc.
 
 ;; Maintainer: FSF
 ;; Keywords: help, internal
@@ -722,6 +723,20 @@
                      (princ ".\n"))
                  (princ "  This variable is a file local variable.\n")))
 
+             (when (memq variable ignored-local-variables)
+               (setq extra-line t)
+               (princ "  This variable is ignored when used as a file local \
+variable.\n"))
+
+             ;; Can be both risky and safe, eg auto-fill-function.
+             (when (risky-local-variable-p variable)
+               (setq extra-line t)
+               (princ "  This variable is potentially risky when used as a \
+file local variable.\n")
+               (when (assq variable safe-local-variable-values)
+                 (princ "  However, you have added it to \
+`safe-local-variable-values'.\n")))
+
              (when safe-var
                 (setq extra-line t)
                (princ "  This variable is safe as a file local variable ")