[Emacs-diffs] emacs/lisp ChangeLog tar-mode.el

[Stefan Monnier]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Stefan Monnier <monnier>        09/03/14 03:03:27

Modified files:
        lisp           : ChangeLog tar-mode.el 

Log message:
        (tar-extract): Setup the buffer's name, undo-list, and
        modified status before running the major-mode.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15469&r2=1.15470
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/tar-mode.el?cvsroot=emacs&r1=1.138&r2=1.139

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15469
retrieving revision 1.15470
diff -u -b -r1.15469 -r1.15470
--- ChangeLog   14 Mar 2009 02:11:20 -0000      1.15469
+++ ChangeLog   14 Mar 2009 03:03:25 -0000      1.15470
@@ -5,6 +5,9 @@
 
 2009-03-14  Stefan Monnier  <address@hidden>
 
+       * tar-mode.el (tar-extract): Setup the buffer's name, undo-list, and
+       modified status before running the major-mode.
+
        * simple.el (undo): Don't loop when encountering empty undo records.
 
 2009-03-13  Tassilo Horn  <address@hidden>

Index: tar-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/tar-mode.el,v
retrieving revision 1.138
retrieving revision 1.139
diff -u -b -r1.138 -r1.139
--- tar-mode.el 13 Mar 2009 15:37:06 -0000      1.138
+++ tar-mode.el 14 Mar 2009 03:03:27 -0000      1.139
@@ -622,10 +622,6 @@
 
 See also: variables `tar-update-datestamp' and `tar-anal-blocksize'.
 \\{tar-mode-map}"
-  ;; this is not interactive because you shouldn't be turning this
-  ;; mode on and off.  You can corrupt things that way.
-  ;; rms: with permanent locals, it should now be possible to make this work
-  ;; interactively in some reasonable fashion.
   (make-local-variable 'tar-parse-info)
   (set (make-local-variable 'require-final-newline) nil) ; binary data, dude...
   (set (make-local-variable 'local-enable-local-variables) nil)
@@ -839,15 +835,13 @@
           (setq default-directory
                 (with-current-buffer tar-buffer
                   default-directory))
-          (normal-mode)  ; pick a mode.
           (rename-buffer bufname)
-          (make-local-variable 'tar-superior-buffer)
-          (make-local-variable 'tar-superior-descriptor)
-          (setq tar-superior-buffer tar-buffer)
-          (setq tar-superior-descriptor descriptor)
-          (setq buffer-read-only read-only-p)
           (set-buffer-modified-p nil)
           (setq buffer-undo-list undo-list)
+          (normal-mode)  ; pick a mode.
+          (set (make-local-variable 'tar-superior-buffer) tar-buffer)
+          (set (make-local-variable 'tar-superior-descriptor) descriptor)
+          (setq buffer-read-only read-only-p)
           (tar-subfile-mode 1)))
       (if view-p
          (view-buffer