[Emacs-diffs] Changes to emacs/src/marker.c

[Stefan Monnier]

Index: emacs/src/marker.c
diff -c emacs/src/marker.c:1.40 emacs/src/marker.c:1.41
*** emacs/src/marker.c:1.40     Sun Apr  6 16:33:59 2003
--- emacs/src/marker.c  Thu Jun 26 19:17:50 2003
***************
*** 1,5 ****
  /* Markers: examining, setting and deleting.
!    Copyright (C) 1985, 1997, 1998 Free Software Foundation, Inc.
  
  This file is part of GNU Emacs.
  
--- 1,5 ----
  /* Markers: examining, setting and deleting.
!    Copyright (C) 1985, 1997, 1998, 2003 Free Software Foundation, Inc.
  
  This file is part of GNU Emacs.
  
***************
*** 133,139 ****
       struct buffer *b;
       int charpos;
  {
!   Lisp_Object tail;
    int best_above, best_above_byte;
    int best_below, best_below_byte;
  
--- 133,139 ----
       struct buffer *b;
       int charpos;
  {
!   struct Lisp_Marker *tail;
    int best_above, best_above_byte;
    int best_below, best_below_byte;
  
***************
*** 169,186 ****
    if (b == cached_buffer && BUF_MODIFF (b) == cached_modiff)
      CONSIDER (cached_charpos, cached_bytepos);
  
!   tail = BUF_MARKERS (b);
!   while (! NILP (tail))
      {
!       CONSIDER (XMARKER (tail)->charpos, XMARKER (tail)->bytepos);
  
        /* If we are down to a range of 50 chars,
         don't bother checking any other markers;
         scan the intervening chars directly now.  */
        if (best_above - best_below < 50)
        break;
- 
-       tail = XMARKER (tail)->chain;
      }
  
    /* We get here if we did not exactly hit one of the known places.
--- 169,183 ----
    if (b == cached_buffer && BUF_MODIFF (b) == cached_modiff)
      CONSIDER (cached_charpos, cached_bytepos);
  
!   for (tail = BUF_MARKERS (b); tail; tail = tail->next)
      {
!       CONSIDER (tail->charpos, tail->bytepos);
  
        /* If we are down to a range of 50 chars,
         don't bother checking any other markers;
         scan the intervening chars directly now.  */
        if (best_above - best_below < 50)
        break;
      }
  
    /* We get here if we did not exactly hit one of the known places.
***************
*** 328,334 ****
       struct buffer *b;
       int bytepos;
  {
!   Lisp_Object tail;
    int best_above, best_above_byte;
    int best_below, best_below_byte;
  
--- 325,331 ----
       struct buffer *b;
       int bytepos;
  {
!   struct Lisp_Marker *tail;
    int best_above, best_above_byte;
    int best_below, best_below_byte;
  
***************
*** 355,372 ****
    if (b == cached_buffer && BUF_MODIFF (b) == cached_modiff)
      CONSIDER (cached_bytepos, cached_charpos);
  
!   tail = BUF_MARKERS (b);
!   while (! NILP (tail))
      {
!       CONSIDER (XMARKER (tail)->bytepos, XMARKER (tail)->charpos);
  
        /* If we are down to a range of 50 chars,
         don't bother checking any other markers;
         scan the intervening chars directly now.  */
        if (best_above - best_below < 50)
        break;
- 
-       tail = XMARKER (tail)->chain;
      }
  
    /* We get here if we did not exactly hit one of the known places.
--- 352,366 ----
    if (b == cached_buffer && BUF_MODIFF (b) == cached_modiff)
      CONSIDER (cached_bytepos, cached_charpos);
  
!   for (tail = BUF_MARKERS (b); tail; tail = tail->next)
      {
!       CONSIDER (tail->bytepos, tail->charpos);
  
        /* If we are down to a range of 50 chars,
         don't bother checking any other markers;
         scan the intervening chars directly now.  */
        if (best_above - best_below < 50)
        break;
      }
  
    /* We get here if we did not exactly hit one of the known places.
***************
*** 388,394 ****
         It will last until the next GC.
         But don't do it if BUF_MARKERS is nil;
         that is a signal from Fset_buffer_multibyte.  */
!       if (record && ! NILP (BUF_MARKERS (b)))
        {
          Lisp_Object marker, buffer;
          marker = Fmake_marker ();
--- 382,388 ----
         It will last until the next GC.
         But don't do it if BUF_MARKERS is nil;
         that is a signal from Fset_buffer_multibyte.  */
!       if (record && BUF_MARKERS (b))
        {
          Lisp_Object marker, buffer;
          marker = Fmake_marker ();
***************
*** 421,427 ****
         It will last until the next GC.
         But don't do it if BUF_MARKERS is nil;
         that is a signal from Fset_buffer_multibyte.  */
!       if (record && ! NILP (BUF_MARKERS (b)))
        {
          Lisp_Object marker, buffer;
          marker = Fmake_marker ();
--- 415,421 ----
         It will last until the next GC.
         But don't do it if BUF_MARKERS is nil;
         that is a signal from Fset_buffer_multibyte.  */
!       if (record && BUF_MARKERS (b))
        {
          Lisp_Object marker, buffer;
          marker = Fmake_marker ();
***************
*** 489,500 ****
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
    /* If position is nil or a marker that points nowhere,
       make this marker point nowhere.  */
    if (NILP (position)
        || (MARKERP (position) && !XMARKER (position)->buffer))
      {
!       unchain_marker (marker);
        return marker;
      }
  
--- 483,496 ----
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
+   m = XMARKER (marker);
+ 
    /* If position is nil or a marker that points nowhere,
       make this marker point nowhere.  */
    if (NILP (position)
        || (MARKERP (position) && !XMARKER (position)->buffer))
      {
!       unchain_marker (m);
        return marker;
      }
  
***************
*** 507,519 ****
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (marker);
          return marker;
        }
      }
  
-   m = XMARKER (marker);
- 
    /* Optimize the special case where we are copying the position
       of an existing marker, and MARKER is already in the same buffer.  */
    if (MARKERP (position) && b == XMARKER (position)->buffer
--- 503,513 ----
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (m);
          return marker;
        }
      }
  
    /* Optimize the special case where we are copying the position
       of an existing marker, and MARKER is already in the same buffer.  */
    if (MARKERP (position) && b == XMARKER (position)->buffer
***************
*** 544,553 ****
  
    if (m->buffer != b)
      {
!       unchain_marker (marker);
        m->buffer = b;
!       m->chain = BUF_MARKERS (b);
!       BUF_MARKERS (b) = marker;
      }
  
    return marker;
--- 538,547 ----
  
    if (m->buffer != b)
      {
!       unchain_marker (m);
        m->buffer = b;
!       m->next = BUF_MARKERS (b);
!       BUF_MARKERS (b) = m;
      }
  
    return marker;
***************
*** 565,576 ****
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
    /* If position is nil or a marker that points nowhere,
       make this marker point nowhere.  */
    if (NILP (pos)
        || (MARKERP (pos) && !XMARKER (pos)->buffer))
      {
!       unchain_marker (marker);
        return marker;
      }
  
--- 559,572 ----
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
+   m = XMARKER (marker);
+ 
    /* If position is nil or a marker that points nowhere,
       make this marker point nowhere.  */
    if (NILP (pos)
        || (MARKERP (pos) && !XMARKER (pos)->buffer))
      {
!       unchain_marker (m);
        return marker;
      }
  
***************
*** 583,595 ****
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (marker);
          return marker;
        }
      }
  
-   m = XMARKER (marker);
- 
    /* Optimize the special case where we are copying the position
       of an existing marker, and MARKER is already in the same buffer.  */
    if (MARKERP (pos) && b == XMARKER (pos)->buffer
--- 579,589 ----
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (m);
          return marker;
        }
      }
  
    /* Optimize the special case where we are copying the position
       of an existing marker, and MARKER is already in the same buffer.  */
    if (MARKERP (pos) && b == XMARKER (pos)->buffer
***************
*** 620,629 ****
  
    if (m->buffer != b)
      {
!       unchain_marker (marker);
        m->buffer = b;
!       m->chain = BUF_MARKERS (b);
!       BUF_MARKERS (b) = marker;
      }
  
    return marker;
--- 614,623 ----
  
    if (m->buffer != b)
      {
!       unchain_marker (m);
        m->buffer = b;
!       m->next = BUF_MARKERS (b);
!       BUF_MARKERS (b) = m;
      }
  
    return marker;
***************
*** 641,646 ****
--- 635,641 ----
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
+   m = XMARKER (marker);
  
    if (NILP (buffer))
      b = current_buffer;
***************
*** 651,663 ****
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (marker);
          return marker;
        }
      }
  
-   m = XMARKER (marker);
- 
    /* In a single-byte buffer, the two positions must be equal.  */
    if (BUF_Z (b) == BUF_Z_BYTE (b)
        && charpos != bytepos)
--- 646,656 ----
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (m);
          return marker;
        }
      }
  
    /* In a single-byte buffer, the two positions must be equal.  */
    if (BUF_Z (b) == BUF_Z_BYTE (b)
        && charpos != bytepos)
***************
*** 671,680 ****
  
    if (m->buffer != b)
      {
!       unchain_marker (marker);
        m->buffer = b;
!       m->chain = BUF_MARKERS (b);
!       BUF_MARKERS (b) = marker;
      }
  
    return marker;
--- 664,673 ----
  
    if (m->buffer != b)
      {
!       unchain_marker (m);
        m->buffer = b;
!       m->next = BUF_MARKERS (b);
!       BUF_MARKERS (b) = m;
      }
  
    return marker;
***************
*** 692,697 ****
--- 685,691 ----
    register struct Lisp_Marker *m;
  
    CHECK_MARKER (marker);
+   m = XMARKER (marker);
  
    if (NILP (buffer))
      b = current_buffer;
***************
*** 702,714 ****
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (marker);
          return marker;
        }
      }
  
-   m = XMARKER (marker);
- 
    if (charpos < BUF_BEGV (b))
      charpos = BUF_BEGV (b);
    if (charpos > BUF_ZV (b))
--- 696,706 ----
        /* If buffer is dead, set marker to point nowhere.  */
        if (EQ (b->name, Qnil))
        {
!         unchain_marker (m);
          return marker;
        }
      }
  
    if (charpos < BUF_BEGV (b))
      charpos = BUF_BEGV (b);
    if (charpos > BUF_ZV (b))
***************
*** 731,740 ****
  
    if (m->buffer != b)
      {
!       unchain_marker (marker);
        m->buffer = b;
!       m->chain = BUF_MARKERS (b);
!       BUF_MARKERS (b) = marker;
      }
  
    return marker;
--- 723,732 ----
  
    if (m->buffer != b)
      {
!       unchain_marker (m);
        m->buffer = b;
!       m->next = BUF_MARKERS (b);
!       BUF_MARKERS (b) = m;
      }
  
    return marker;
***************
*** 749,794 ****
  
  void
  unchain_marker (marker)
!      register Lisp_Object marker;
  {
!   register Lisp_Object tail, prev, next;
!   register EMACS_INT omark;
    register struct buffer *b;
  
!   b = XMARKER (marker)->buffer;
    if (b == 0)
      return;
  
    if (EQ (b->name, Qnil))
      abort ();
  
!   XMARKER (marker)->buffer = 0;
  
    tail = BUF_MARKERS (b);
!   prev = Qnil;
!   while (! GC_NILP (tail))
      {
!       next = XMARKER (tail)->chain;
!       XUNMARK (next);
  
!       if (XMARKER (marker) == XMARKER (tail))
        {
!         if (NILP (prev))
            {
              BUF_MARKERS (b) = next;
              /* Deleting first marker from the buffer's chain.  Crash
                 if new first marker in chain does not say it belongs
                 to the same buffer, or at least that they have the same
                 base buffer.  */
!             if (!NILP (next) && b->text != XMARKER (next)->buffer->text)
                abort ();
            }
          else
!           {
!             omark = XMARKBIT (XMARKER (prev)->chain);
!             XMARKER (prev)->chain = next;
!             XSETMARKBIT (XMARKER (prev)->chain, omark);
!           }
          /* We have removed the marker from the chain;
             no need to scan the rest of the chain.  */
          return;
--- 741,780 ----
  
  void
  unchain_marker (marker)
!      register struct Lisp_Marker *marker;
  {
!   register struct Lisp_Marker *tail, *prev, *next;
    register struct buffer *b;
  
!   b = marker->buffer;
    if (b == 0)
      return;
  
    if (EQ (b->name, Qnil))
      abort ();
  
!   marker->buffer = 0;
  
    tail = BUF_MARKERS (b);
!   prev = NULL;
!   while (tail)
      {
!       next = tail->next;
  
!       if (marker == tail)
        {
!         if (!prev)
            {
              BUF_MARKERS (b) = next;
              /* Deleting first marker from the buffer's chain.  Crash
                 if new first marker in chain does not say it belongs
                 to the same buffer, or at least that they have the same
                 base buffer.  */
!             if (next && b->text != next->buffer->text)
                abort ();
            }
          else
!           prev->next = next;
          /* We have removed the marker from the chain;
             no need to scan the rest of the chain.  */
          return;
***************
*** 888,894 ****
       (position)
       Lisp_Object position;
  {
!   register Lisp_Object tail;
    register int charno;
  
    charno = XINT (position);
--- 874,880 ----
       (position)
       Lisp_Object position;
  {
!   register struct Lisp_Marker *tail;
    register int charno;
  
    charno = XINT (position);
***************
*** 898,907 ****
    if (charno > Z)
      charno = Z;
  
!   for (tail = BUF_MARKERS (current_buffer);
!        !NILP (tail);
!        tail = XMARKER (tail)->chain)
!     if (XMARKER (tail)->charpos == charno)
        return Qt;
  
    return Qnil;
--- 884,891 ----
    if (charno > Z)
      charno = Z;
  
!   for (tail = BUF_MARKERS (current_buffer); tail; tail = tail->next)
!     if (tail->charpos == charno)
        return Qt;
  
    return Qnil;
***************
*** 914,924 ****
       struct buffer *buf;
  {
    int total = 0;
!   Lisp_Object tail;
  
!   for (tail = BUF_MARKERS (buf);
!        !NILP (tail);
!        tail = XMARKER (tail)->chain)
      total++;
  
    return total;
--- 898,906 ----
       struct buffer *buf;
  {
    int total = 0;
!   struct Lisp_Marker *tail;
  
!   for (tail = BUF_MARKERS (buf); tail; tail = tail->next)
      total++;
  
    return total;