From 3a7809f9cc7214e843c20e3c216933bf8bbcdbb2 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 31 Jan 2025 14:42:33 -0800 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20use=20garbage=20after=20tty=5Ff?= =?UTF-8?q?rame=5Fat=20returns=20nil?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * src/term.c (handle_one_term_event): Don’t access possibly uninitialized storage if frame is nil. This fixes an issue introduced in commit 5eae7f5227c7789dea45cef26fec17c057024670 dated 2025-01-26 14:43:51 -0800. Issue caught by --enable-gcc-warnings, which enables -Wanalyzer-use-of-uninitialized-value with gcc (GCC) 14.2.1 20250110 (Red Hat 14.2.1-7). --- src/term.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/term.c b/src/term.c index a058cb1f62a..f307d709316 100644 --- a/src/term.c +++ b/src/term.c @@ -2767,8 +2767,8 @@ term_mouse_click (struct input_event *result, Gpm_Event *event, int handle_one_term_event (struct tty_display_info *tty, const Gpm_Event *event_in) { - int child_x, child_y; - Lisp_Object frame = tty_frame_at (event_in->x, event_in->y, &child_x, &child_y); + int child_x = event_in->x, child_y = event_in->y; + Lisp_Object frame = tty_frame_at (child_x, child_y, &child_x, &child_y); Gpm_Event event = *event_in; event.x = child_x; event.y = child_y; -- 2.45.2