[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA] New package: auth-source-xoauth2-plugin
From: |
Xiyue Deng |
Subject: |
Re: [ELPA] New package: auth-source-xoauth2-plugin |
Date: |
Wed, 29 Jan 2025 17:35:57 -0800 |
User-agent: |
Notmuch/0.38.1 (https://notmuchmail.org) Emacs/30.0.93 (x86_64-pc-linux-gnu) |
Hi Philip,
Philip Kaludercic <philipk@posteo.net> writes:
> Xiyue Deng <manphiz@gmail.com> writes:
>
>> Hi,
>>
>> I'd like to submit my small addon to enable xoauth2 support for
>> inclusion in GNU (or non-GNU) Elpa, whichever is the best fit. This is
>> a follow-up of the discussion at [1]. This package depends on
>> oauth2.el[2] for xoauth2 handling and advices the auth-source code to
>> enable xoauth2 support. The code is hosted on GitLab[3]. I have been
>> testing this for a few months and it seems to work fairly reliably for
>> my Gmail so I think it's probably time to let more people try it.
>>
>> A short description is below:
>>
>> ;; An auth-source plugin to enable xoauth2 support.
>>
>> ;; This package provides a global minor mode for enabling xoauth2 in
>> ;; auth-source. Once adding information required for xoauth2 authentication
>> in
>> ;; your auth-source file and enabling the global minor mode, one can
>> ;; authenticate through xoauth2 to supported services, e.g. Gmail, etc.
>>
>> ;; See README.org for a more detailed introduction and usages.
>>
>> As I don't have push access, please let me know how to proceed. Thanks
>> in advance!
>
> I can add it for you do elpa.git, don't worry about that. Code-wise, I
> don't have any comments, I just wonder if you really want to call the
> package "auth-source-xoauth2-plugin" or if "auth-source-xoauth2" would
> be enough?
>
Thanks again for your review on an early draft! I choose this name
because there is already an "auth-source-xoauth2" available on
GitHub[1].
I would like to note that the general ideal of my plugin shares with
"auth-source-xoauth2" that both advice the auth-source-search backends
to calculate what is needed for xoauth2 to work. The implementation is
done independently, and besides several obvious coding choice ("*-let"
assignments and "setq"s) there is no derivative relation with that code.
I hope this explanation is sufficient to declare my code is not a
derivative work of "auth-source-xoauth2", but do let me know if further
clarification is required.
Thanks again in advance!
[1] https://github.com/ccrusius/auth-source-xoauth2
--
Regards,
Xiyue Deng
signature.asc
Description: PGP signature