emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master e54b94c28cd: Use @xref more consistently; "See @ref" -> "@xre


From: Michael Albinus
Subject: Re: master e54b94c28cd: Use @xref more consistently; "See @ref" -> "@xref"
Date: Mon, 27 Jan 2025 18:24:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> I said it already: if a contributor would run the relevant tests for his
>> changes, it would be a big win already. Like 'make -C test
>> xt-mouse-tests' prior committing a change in xt-mouse.el, quoting a
>> recent case.
>
> Yes, very much agreed.

What about this?

diff --git a/CONTRIBUTE b/CONTRIBUTE
index 936aa326e89..3d4c39850b8 100644
--- a/CONTRIBUTE
+++ b/CONTRIBUTE
@@ -172,6 +172,12 @@ test 'out-of-tree' builds as well, i.e.:
     ../path-to-emacs-sources/configure
     make

+It is a good practice to run the unit test of a change prior committing.
+If you have changed, e.g., the file xt-mouse.el, you can run the unit
+tests via
+
+    make && make -C test xt-mouse-tests
+
 ** Commit messages

 Ordinarily, a changeset you commit should contain a description of the
Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]