Re: master 6e2e7265a04: Prefer static switch-case checking in pdumper

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 26 Jan 2025 21:59:08 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>> We are using COLD_OP_NATIVE_SUBR inconsistently: on the one hand it is
>> defined unconditionally in the enumeration, and used unconditionally
>> in dump_subr; OTOH it is used in dump_drain_cold_data only in the
>> native-comp build.  Which one do we want: define and use it in the
>> code unconditionally, or only if HAVE_NATIVE_COMP?  If we want static
>> checks for switch values, we should decide either or.
>
> Btw, my preference is to use COLD_OP_NATIVE_SUBR unconditionally.  It
> makes the code more readable, whereas realizing that a native-compiled
> subr cannot happen in a build without native compilation is a
> no-brainer.  But if you prefer the other possibility, I won't argue.

I installed it the other way around, because that was what we already
had, but feel free to change it if you think it's better.