emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] externals/exwm 9cdfe95066: Work around a bug where the tab-li


From: Steven Allen
Subject: Re: [elpa] externals/exwm 9cdfe95066: Work around a bug where the tab-line isn't taken into account
Date: Fri, 17 Jan 2025 09:37:23 -0800

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> --- a/exwm-layout.el
>> +++ b/exwm-layout.el
>> @@ -117,6 +117,8 @@ See variable `exwm-layout-auto-iconify'."
>>           (width (- (pop edges) x))
>>           (height (- (pop edges) y))
>>           frame-x frame-y frame-width frame-height)
>> +    (when (eval-when-compile (< emacs-major-version 31))
>> +      (setq y (+ y (window-tab-line-height window))))
>>      (with-current-buffer (exwm--id->buffer id)
>>        (when exwm--floating-frame
>>          (setq frame-width (frame-pixel-width exwm--floating-frame)
>
> I think this will give the wrong result if you compile the package with
> Emacs-30 and then use it with Emacs-31.

Good point. I assumed most users recompiled their packages between Emacs
versions but that's not a given. I've merged a patch to check at runtime 
instead.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]