emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "Final" version of tty child frames


From: martin rudalics
Subject: Re: "Final" version of tty child frames
Date: Fri, 17 Jan 2025 16:08:04 +0100
User-agent: Mozilla Thunderbird

> Since is_tty_selected means the window set_cursor_from_row is called
> for is the one from the parent frame (right?), any condition that
> looks at glyph->charpos without first verifying the glyph is from that
> window's frame must be wrong.  Do you agree?

I do.

> If the cursor should be hidden because of an overlapping child frame,
> how come you didn't detect that when you found the first glyph whose
> FRAME is not the window's frame?

I do detect that here

        if (is_tty_selected && f != glyph->frame)

The original code didn't.

> Anyway, this is wrong for bidirectional display, where a glyph to the
> right of another one could have its charpos smaller.

This must be handled in row->reversed_p.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]