Re: New "make benchmark" target

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Wed, 15 Jan 2025 14:20:42 -0800
>> Cc: acorallo@gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, 
>>      emacs-devel@gnu.org
>> 
>> Pip Cet <pipcet@protonmail.com> writes:
>> 
>> > "Eli Zaretskii" <eliz@gnu.org> writes:
>> >
>> >>> I'm happy to change the scratch/elisp-benchmarks branch in the ways
>> >>> we've discussed, and it should be merged, but if someone decides to
>> >>> incrementally solve some of the issues, that, while not very harmful,
>> >>> would be an inefficient use of resources.
>> >>
>> >> Let's hear what Andrea thinks about the issues you reported (let's
>> >> please discuss them on the bug tracker, not here), and let's take it
>> >> from there.
>> >
>> > Sure, just let me know when we can merge the branch (assuming you meant
>> > to say that the merge, too, should wait for Andrea's thoughts) or which
>> > other changes are required!
>> 
>> Is there anything left to do here that is blocking the merge?
>
> I didn't follow the discussions too closely, but if there are no
> unresolved issues left between Pip and Andrea, I think this can land.
>
> Andrea, any objections or comments?

I've no objections, only two questions:

1- admin/elpa2emacs.sh looks elisp-benchmarks specific, if that's the
   case perhaps should have a better name?  Otherwise we should probably
   make it general?

2- What is the workflow for importing into emacs.git existing changes in
   elisp-benchmarks?  I tried to run elpa2emacs.sh as suggested but I do
   get an error (not sure if the suggested invocation is for the initial
   import, for merging incremental changes or both).


  Andrea