emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support


From: Ihor Radchenko
Subject: Re: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support)
Date: Wed, 15 Jan 2025 17:18:54 +0000

Richard Lawrence <rwl@recursewithless.net> writes:

>> It might work, but you will need to wrap your code into the let above.
>> I think that it is what I suggested at the very beginning:
>
> Yes indeed. I still think this is a bit much to ask.

... and I agree with you :)

> What wasn't clear
> to me then was whether the value is only used at compile time. If
> modifying one of these variables at run time is sufficient, then I think
> there must be some other solution.

The value is used both at compile and runtime. However, there is only
practical benefit of using standard properties when it is used at
compile time. At runtime, standard properties are comparable (slightly
worse) in terms of performance.

> What do you think about making one of these variables
> (org-element--standard-properties or org-element--standard-properties-idxs)
> buffer-local? 

Extremely bad idea.
The current buffer active while processing the parse tree (which might
as well be stored in a variable) must not affect its interpretation.
Otherwise, we will run into all kinds of hard-to-find bugs.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]