emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding git-commit highlight mode?


From: Konstantin Kharlamov
Subject: Re: Adding git-commit highlight mode?
Date: Wed, 15 Jan 2025 18:59:19 +0300
User-agent: Evolution 3.54.2

On Fri, 2025-01-03 at 21:02 +0000, Sean Whitton wrote:
> Hello,
> 
> On Thu 02 Jan 2025 at 03:53pm -06, Stefan Kangas wrote:
> 
> > AFAICT, the 50 character line limit for the summary line is not
> > really
> > followed very strictly in practice by most projects, including the
> > Linux
> > kernel.  It's more of a recommendation.  Even the link you provide
> > above
> > says that it's "a good idea" to use "no more than 50 characters"
> > for it.
> > For that reason, I think that this should be a warning (with a
> > highlight
> > if you go over), and not a hard limit.
> > 
> > In `git-commit-mode`, the user option `git-commit-summary-max-
> > length' is
> > 68 by default, which strikes me as unopinionated enough.
> 
> As Jonas mentioned, some of the things suggested in this thread
> overlap
> with our existing vc-git-log-edit-mode.  For example, we already have
> vc-git-log-edit-summary-target-len and vc-git-log-edit-summary-max-
> len.
> 
> I haven't looked at your code, Jim, but hopefully it could avoid too
> much reimplementation/crossover with vc-git-log-edit-mode if we are
> going to put it in emacs.git.
> I will happily review what you'd actually like to include.
> 
> (As the VC maintainer, I would have appreciated being CC'd on this
> thread at some point; glad I caught it anyway.)

Hello Jim and Sean! I see the thread has been silent for 1.5 weeks, so
just wondering if you two got connected offlist or if anything at all
is happening regarding the highlighting mode…? I looked at `git-
command-modes` repo and I see no activity on any of the branches, so
just wondering if anything is going on or is being planned 😊



reply via email to

[Prev in Thread] Current Thread [Next in Thread]