Re: Functions transpose/rotate/flip windows

[Pranshu Sharma]

Eshel Yaron <me@eshelyaron.com> writes:

> Hi all,
>
> martin rudalics <rudalics@gmx.at> writes:
>
>>> Ok, I fixed them now.  A new diff is attached.
>>
>> I pushed window-x.el to master now without any further testing or
>> looking into it.  I plan to fix a few things in it but maybe Eli wants
>> to make some major corrections first.
>
> Thanks for working on these additions, the new commands seem neat.
>
> The only functional issue I ran into is that rotate-windows and
> rotate-windows-back seem to leave the wrong window selected (the
> selection does not follow the rotation).
>
> Other than that, here are some clean up suggestions from a quick pass:
>

I had a look, everything seems good.  That was clever usage of 'xor', I
didn't know it was practical for high level programming.  One thing I
would also do, is remane the paraemter in a lambda that takes the
argment 'e' in window--transpose-1.  I haven't checked if the patch
compiles well, but I asssume you have, so it should be fine.