[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: igc, macOS avoiding signals
From: |
Eli Zaretskii |
Subject: |
Re: igc, macOS avoiding signals |
Date: |
Sat, 04 Jan 2025 16:17:41 +0200 |
> From: Helmut Eller <eller.helmut@gmail.com>
> Cc: Pip Cet <pipcet@protonmail.com>, gerd.moellmann@gmail.com,
> spd@toadstyle.org, emacs-devel@gnu.org
> Date: Sat, 04 Jan 2025 14:59:50 +0100
>
> On Fri, Jan 03 2025, Helmut Eller wrote:
> [...]
> > I'm not sure if those differences are acceptable. I also have no good
> > idea how to reduce it, except inserting more calls to maybe_quit.
>
> It seems that calling maybe_quit before and after calling functions
> would cure this problem. With the original maybe_quit restored, as in
> the attached patch, the foo example looks so:
>
> 1986 100% main
> 1986 100% record-samples
> 1986 100% foo
> 1214 61% float-time
>
> Compared to the original
>
> 1074 54% float-time
>
> that seems pretty ok. Also the bar example
>
> 812 80% animate-place-char
> 6 0% window-start
> 29 2% beginning-of-line
> 29 2% delete-char
> 6 0% undo-auto-amalgamate
> 36 3% insert-char
> 390 38% move-to-column
> 11 1% undo-auto--undoable-change
>
> looks quite good to me.
>
> WDYT?
I'd make these extra calls only call the SIGPROF handler if the
counter says some signals were missed. There's no need to affect
other handlers without a good reason.
- Re: igc, macOS avoiding signals, (continued)
- Re: igc, macOS avoiding signals, Eli Zaretskii, 2025/01/03
- Re: igc, macOS avoiding signals, Pip Cet, 2025/01/04
- Re: igc, macOS avoiding signals, Gerd Möllmann, 2025/01/04
- Re: igc, macOS avoiding signals, Gerd Möllmann, 2025/01/04
- Re: igc, macOS avoiding signals, Eli Zaretskii, 2025/01/04
- Re: igc, macOS avoiding signals, Gerd Möllmann, 2025/01/04
- Re: igc, macOS avoiding signals, Eli Zaretskii, 2025/01/04
- Re: igc, macOS avoiding signals, Gerd Möllmann, 2025/01/04
Re: igc, macOS avoiding signals, Helmut Eller, 2025/01/04
- Re: igc, macOS avoiding signals, Gerd Möllmann, 2025/01/04
- Re: igc, macOS avoiding signals,
Eli Zaretskii <=
- Re: igc, macOS avoiding signals, Helmut Eller, 2025/01/04
- Re: igc, macOS avoiding signals, Eli Zaretskii, 2025/01/04
- Re: igc, macOS avoiding signals, Pip Cet, 2025/01/04
- Re: igc, macOS avoiding signals, Helmut Eller, 2025/01/04