[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merge haskell-ts-mode in upstream
From: |
Pranshu Sharma |
Subject: |
Re: Merge haskell-ts-mode in upstream |
Date: |
Mon, 30 Dec 2024 01:10:24 +1000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Philip Kaludercic <philipk@posteo.net> writes:
>>>>> I see that you have started a new repository. Do you want us to
>>>>> mirror
>>>>> your changes with all the commit history, or are you OK with us
>>>>> just
>>>>> copying over the coded periodically whenever you want to update
>>>>> the code?
>>>>
>>>> Ok, it seems like I'll be sticking to git one anyway, since
>>>> git-hg-bridge or something doesn't work. I am fine with using the
>>>> old
>>>> repo.
>>>
>>> Wait, I am confused. The initial proposal was to add the package to
>>> emacs.git, right?
>>
>> Yes, but iiuc it will still have own repo and emacs will just mirror
>> it
>> or smth.
>
> Ok, that is fine. You'll just have to ping the mailing list whenever
> there is a new release.
>
Ok, this sounds better, I would prefer to do this.
>
[29 lines omitted]
>>
>> Not really, it is mostly convince for C-M-h TAB, but since it is
>> meant ot be
>> used a lot, it get it's own special binding. The rules are tiny bit
>> different.
>
> But then my question is why doesn't M-q in Emacs 30 do the same as
> well?
> If it is invoked in a prog-mode outside of a comment or a string, it
> should mark the defun and indent it, or does it not do that for
> tree-sitter modes?
>
Turns out it does, I thought it used M-h instead of C-M-h to find the
region to inden. I removed the old function.
>>>> I attach new file, I have also pushed changes to codebrg repo.
>>>
>>> I think it would be someone with more Tree Sitter experience could
>>> take
>>> a look at the code as well. Perhaps we should make this more
>>> formal by
>>> moving over to the bug tracker?
>>
>> Sounds good.
>
> 1+
Ok, done
Thanks again for your inital code reivew and patiant replys
--
Pranshu Sharma <https://p.bauherren.ovh>