emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Making decoded-times and calendar dates compatible?


From: Eli Zaretskii
Subject: Re: [PATCH] Re: Making decoded-times and calendar dates compatible?
Date: Sat, 21 Dec 2024 12:45:32 +0200

> From: Richard Lawrence <rwl@recursewithless.net>
> Cc: emacs-devel@gnu.org
> Date: Mon, 16 Dec 2024 21:05:30 +0100
> 
> Richard Stallman <rms@gnu.org> writes:
> >   The docstrings of the functions
> >
> >   > calendar-extract-year
> >   > calendar-extract-month
> >   > calendar-extract-day
> >
> >   > are where the (MONTH DAY YEAR) format is mentioned.
> >
> > Would someoe like to add some comments at the start of the file
> > documenging this data structure?
> 
> Attached is a patch which adds such a comment, based on my previous
> message; let me know if I should open a bug report for this.

In general, yes.  But we can make exceptions.

I've now installed your change on the emacs-30 release branch.

> For now I take it that it's better not to touch the calendar code? I
> don't think there is any constructor function for dates, or at least, I
> see that throughout the calendar code, there are many uses of "(list
> month day year)" to construct dates, so there might be a lot of code to
> fix if we change the representation, and it might be hard to be sure
> we've made all the necessary changes. Anyway, this is more work than I
> want to do at the moment, though I'm willing to take a stab at it
> eventually if others here think it would be worthwhile.

I think you are right.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]