Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 12:59:44 +0100
> 
> Michael Albinus <michael.albinus@gmx.de> writes:
> 
> > Gerd Moellmann <gerd@gnu.org> writes:
> >
> > Hi Gerd,
> >
> >>     Merge branch 'scratch/tty-child-frames'
> >>
> >>     Add support for child frames on tty
> >
> > This breaks xt-mouse-tests:
> >
> > --8<---------------cut here---------------start------------->8---
> > # make -C test xt-mouse-tests
> > Test xt-mouse-tracking-basic condition:
> >     (error "tty frame should be used")
> >    FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at 
> > lisp/xt-mouse-tests.el:61
> > Test xt-mouse-tracking-sgr condition:
> >     (error "tty frame should be used")
> >    FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at 
> > lisp/xt-mouse-tests.el:102
> > Test xt-mouse-tracking-utf-8 condition:
> >     (error "tty frame should be used")
> >    FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at 
> > lisp/xt-mouse-tests.el:80
> > --8<---------------cut here---------------end--------------->8---
> >
> > Best regards, Michael.
> 
> Hi Michael,
> 
> The new code now _requires_ a tty frame to be used (decode_tty_frame,
> check_tty), which I think the tests can't provide, running in batch. And
> I'd rather not be less picky for the sake of these tests.

Why is that a problem?  A batch session does have a frame, you just
need to account for that.  I think the test that emits the error is
too strict, and should be relaxed when noninteractive is non-zero.  Or
maybe invert the test and check for !FRAME_WINDOW_P (which would then
allow the frame that exists in the batch session).