emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f92520d009e 1/2: Don't pause display for pending input


From: Gerd Möllmann
Subject: Re: master f92520d009e 1/2: Don't pause display for pending input
Date: Thu, 19 Dec 2024 13:24:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Andrea Corallo <acorallo@gnu.org> writes:

> On a61b968ccfe8fa7e2f1fcf7667781a1c0527389a I see now with
> --with-native-compilation=no --with-x-toolkit=no
>
> =====
> dispnew.c: In function ‘update_menu_bar’:
> dispnew.c:3760:5: error: too many arguments to function ‘update_window’
>  3760 |     update_window (XWINDOW (f->menu_bar_window), true);
>       |     ^~~~~~~~~~~~~
> dispnew.c:97:13: note: declared here
>    97 | static void update_window (struct window *);
>       |             ^~~~~~~~~~~~~
> =======

Thanks. That one should be fixed now. The joy of having n!
configurations.

>
> And with --enable-checking=all --enable-check-lisp-object-type 
> --with-native-compilation=yes
>
> =======
> In file included from dispnew.c:27:
> In function ‘PSEUDOVECTORP’,
>     inlined from ‘FRAMEP’ at lisp.h:3343:10,
>     inlined from ‘FRAME_PARENT_FRAME’ at frame.h:1236:42,
>     inlined from ‘root_frame’ at dispnew.c:3340:10,
>     inlined from ‘is_in_matrix’ at dispnew.c:3877:24,
>     inlined from ‘is_cursor_obscured’ at dispnew.c:3898:8,
>     inlined from ‘terminal_cursor_magic’ at dispnew.c:3917:7,
>     inlined from ‘combine_updates_for_frame’ at dispnew.c:3970:5:
> lisp.h:1096:68: warning: null pointer dereference [-Wnull-dereference]
>  1096 |           && ((XUNTAG (a, Lisp_Vectorlike, union 
> vectorlike_header)->size
>       |                                                                    ^
> =======
>
This one I don't see here, with clang 19. And I must admit I don't
understand it what it is complaining about. The function root_frame
is pretty simple:

  struct frame *
  root_frame (struct frame *f)
  {
    while (FRAME_PARENT_FRAME (f))
      f = FRAME_PARENT_FRAME (f);
    return f;
  }

and FRAME_PARENT_FFAME is

  INLINE struct frame *
  FRAME_PARENT_FRAME (struct frame *f)
  {
    return NILP (f->parent_frame) ? NULL : XFRAME (f->parent_frame);
  }

Any idea?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]