Re: [NonGNU ELPA] New package: eldoc-diffstat

[Stefan Kangas]

Johann Klähn <johann@jklaehn.de> writes:

>> When the mode is toggled on, it could detect automatically that it's in
>> a magit buffer, and do the `eldoc-add-command` setup for users
>> automatically.
>
> I decided to unconditionally add these commands when the package is
> loaded, since this (a) only has to be run once and (b) does not have an
> effect unless eldoc is used in a magit buffer.  And in the latter case
> the user will likely want these as triggers anyways.

This is minor, but we usually recommend against changing behavior from
merely loading a file (as that can happen from merely saying `C-h f`),
so I'd move this to when the mode is loaded.

>> - Caching the results for the current buffer to get instant results
>
> Do you mean eagerly compute diffstat?  Or just remember it indefinitely
> after the first lookup of a commit?

I was thinking of computing it eagerly.  Either or should work, but
keeping it indefinitely might lead to its own issues, for example you
might want to eventually prune the list of commits for which you saved
the diffstat, and so on.