emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use (eval-when-compile 'treesit) to save us from writing declare-fun


From: Andrea Corallo
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Tue, 03 Dec 2024 03:30:09 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

Yuan Fu <casouri@gmail.com> writes:

> Some of my recent changes to c-ts-mode.el uses some more C treesit
> functions, and I (again) forgot to add their declare-function forms to
> c-ts-mode.el, and Andrea has to fix it for me. The main problem for me
> is that (I think) you don’t get warning for them unless you build a
> non-tree-sitter build of Emacs. So I’m prone to forgot about
> them. Also it’s a burden for anyone wanting to use tree-sitter
> functions.
>
> treesit.el already has all the declare-function forms, how about we
> use (eval-when-compile 'treesit) in other files? I believe that should
> alleviate us from adding those declare-function forms in other files?
>
> I want to ask because IIRC I proposed this a while back but there were 
> objections, the details of which I forgot.
>
> Yuan

Hi Yuan,

I was not part of the discussion and I don't know what's the downside of
(eval-when-compile 'treesit), maybe another alternative would be to have
like a dedicated treesit-delcs.el to require where necessary?

  Andrea



reply via email to

[Prev in Thread] Current Thread [Next in Thread]