[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode
From: |
Yuan Fu |
Subject: |
Re: master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode |
Date: |
Mon, 2 Dec 2024 16:38:28 -0800 |
> On Dec 2, 2024, at 1:02 PM, Andrea Corallo <acorallo@gnu.org> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> branch: master
>> commit 63d69bd154987bcc0434e0f85e09bf5dfa07b827
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>>
>> Use new baseline indent rule in c-ts-mode
>>
>> Rework the indent rules in c-ts-mode using
>> c-ts-common-baseline-indent-rule. Also reworked internal
>> functions for setting indent styles to make it simpler and (more
>> importantly) more readable. Now there's a single function,
>> c-ts-mode--simple-indent-rules, that returns a value that can go
>> straight to treesit-simple-indent-rules.
>>
>> * lisp/progmodes/c-ts-mode.el:
>> (c-ts-mode--indent-style-setter): Simplify.
>> (c-ts-mode--get-indent-style): Remove function.
>> (c-ts-mode--prompt-for-style): Use a hard-coded list of styles.
>> This is a tiny downgrade from the computed lists but is
>> acceptable.
>> (c-ts-mode-set-style): Use c-ts-mode--simple-indent-rules.
>> (c-ts-mode--standalone-grandparent): Docstring change.
>> (c-ts-mode--for-loop-indent-rule): New function.
>> (c-ts-mode--preproc-indent-rules): New variable. Copied from
>> old indent rules and added some new rule.
>> (c-ts-mode--macro-heuristic-rules):
>> (c-ts-mode--simple-indent-rules):
>> (c-ts-mode--parenthesized-expression-indent-rule):
>> (c-ts-mode--label-indent-rules): New functions.
>> (c-ts-mode):
>> (c++-ts-mode): Use c-ts-mode--simple-indent-rules.
>> ---
>
> Hi Yuan,
>
> this commit on my test-bench seems to introduce on master the following
> two failures: c-ts-mode-test-indentation-bsd,
> c-ts-mode-test-indentation.
>
> Could you have a look?
>
> Andrea
Hey Andrea, sorry about that. The tests do pass on my machine. How does the
test-bench run the tests?
Yuan