emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-


From: Sean Whitton
Subject: Re: master c3e989ca9d7: New minor mode find-function-mode replaces find-function-setup-keys
Date: Fri, 04 Oct 2024 20:47:14 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Hello,

On Fri 04 Oct 2024 at 01:57pm +02, Eshel Yaron wrote:

> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> On Fri 04 Oct 2024 at 11:56am +02, Eshel Yaron wrote:
>>
>>> Hmm this changes the precedence of these bindings from low (global map)
>>> to very high (minor mode map).  So it's actually quite a breaking change
>>> for those of us that use find-function-setup-keys and override these
>>> bindings in certain major mode maps :/
>>>
>>> How about keeping the behavior of find-function-setup-keys as it was?
>>> We can keep that minor mode too, of course.
>>
>> Ah, that was not intentional.  Thanks for pointing this out.
>>
>> One option is just to keep find-function-setup-keys as it was.
>> Another would be to make the minor mode add the keys to the global map,
>> and remove them from it when deactivated.  How about that?
>
> The first option might be slightly simpler, but either way works for my
> use case, I think.

I prefer the second, so installed that.

-- 
Sean Whitton



reply via email to

[Prev in Thread] Current Thread [Next in Thread]