Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324)

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: casouri@gmail.com,  luangruo@yahoo.com,  stefankangas@gmail.com,
>   emacs-devel@gnu.org
> Date: Mon, 23 Sep 2024 19:24:45 +0200
> 
> > Isn't it a bug in magit that it doesn't do something like that
> > already?  Fill column is just the tip of an iceberg, because a log
> > message is generally human-readable text, and so should benefit from
> > other features of Text mode and its descendants, like spell-checking
> > etc.
> 
> It does try to do "something like that"; AFAIU the two main knobs are:
> 
> * git-commit-major-mode lets users pick their preferred text-adjacent
> major mode (or it lets maintainers choose it, e.g. setting that variable
> in a checked-in .dir-locals.el; the default is text-mode),
> 
> * git-commit-setup-hook lets users turn on useful log-editing features;
> the defcustom includes various opt-in functions.  Robert mentioned
> magit-generate-changelog; there's also git-commit-turn-on-flyspell and
> bug-reference-mode.
> 
> (There's also a mysterious git-commit-setup-changelog-support that
> checks for
> 
>   (fboundp 'log-indent-fill-entry) ; New in Emacs 27
> 
> but I can't find any trace of log-indent-fill-entry in the tree so not
> sure what that's about)

That sounds to me like a heap of patches when just having a full-blown
mode like VC does would have done the job cleanly and seamlessly.

> So what's "missing" from Magit's git-commit.el is a knob dedicated to
> the fill-column for commit messages.

I'm quite sure that soon enough someone will come with more "missing"
stuff.  I still think they should use something very similar to
log-edit-mode there.  It doesn't make much sense not to.  E.g., the
.dir-locals settings would have been in effect for magit users as
well.