[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master e56e4b345a2: Use timer accessors instead of aref/aset
From: |
Mattias Engdegård |
Subject: |
Re: master e56e4b345a2: Use timer accessors instead of aref/aset |
Date: |
Tue, 30 Jul 2024 23:01:16 +0200 |
30 juli 2024 kl. 20.43 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> `vhdl-mode.el` likes to be compatible with XEmacs, so this change might
> be problematic. I'm not sure if it's still important, but I'll also
> note that, according to my reading of the `timer.el` code, the timer
> objects returned by `run-with-idle-timer` already have their `triggered`
> field set to nil.
>
> I'm not sure if it's always been the case, but maybe we could make the
> `aset` conditional on `(< emacs-major-version 30)` (or some older version
> number once we investigate since when this is the case)?
Thank you, yes, I agree but kept the original code for XEmacs only. (Even that
is a stretch, given that XEmacs users are not very likely to use our version.)
Do modify the code if you find it reckless.