emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] feat: add markdown-ts-mode


From: Eli Zaretskii
Subject: Re: [PATCH] feat: add markdown-ts-mode
Date: Thu, 04 Jul 2024 08:08:48 +0300

> From: Rahul Martim Juliato <rahuljuliato@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 03 Jul 2024 16:13:52 -0300
> 
> Could you please provide your insights or suggestions on the patch? Your
> feedback is crucial for moving this forward.

Thanks, please find some comments below.

>  * lisp/textmodes/markdown-ts-mode.el: New file
>  * doc/emacs/emacs.texi: Add Markdown to the manual
>  * etc/NEWS: Announce markdown-ts-mode

Each entry should end with a period.

> index 7d77f13ab21..244c822ee04 100644
> --- a/doc/emacs/emacs.texi
> +++ b/doc/emacs/emacs.texi
> @@ -618,6 +618,7 @@ Top
>  * Enriched Text::       Editing text enriched with fonts, colors, etc.
>  * Text Based Tables::   Commands for editing text-based tables.
>  * Two-Column::          Splitting text columns into separate windows.
> +* Markdown::            Major mode for editing Markdown files.

Where's the actual text of this new section?  Looks like some part(s)
of the patch were left out?

> +(if (treesit-ready-p 'markdown)
> +    (add-to-list 'auto-mode-alist '("\\.md\\'" . markdown-ts-mode)))

Should this also test that the markdown-inline grammar is present?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]