Re: Help with pdumper

[Stefan Monnier]

Gerd Möllmann [2024-06-30 07:16:43] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +static dump_off
>> +dump_markers (struct dump_context *ctx, const struct Lisp_Markers *t)
>> +{
[...]
>> +  dump_object_start (ctx, out, bytesize);
[...]
>> +  dump_off offset = dump_object_finish (ctx, out, bytesize);
[...]
>>    return offset;
>>  }
>
> Is the returned offset right?

I don't know.  I just cargo-culted that code from other examples around.
But AFAICT, it should: `dump_object_start` sets `ctx->obj_offset` which
is what `dump_object_finish` returns.

Helmut Eller [2024-06-30 11:47:14] wrote:
> On Sat, Jun 29 2024, Stefan Monnier wrote:
>> +  for (m_index_t i = 0; i < t->size; i++)
>> +    if (t->markers[i])
>> +      dump_field_fixup_later (ctx, out, t, &t->markers[i]);
> Maybe dump_field_lv_rawptr would work here?

It seems to help (not only it makes the code simpler but it gets me past
this crash)!
Good idea, thanks!


        Stefan