emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MPS: Crash while completing symbol with corfu


From: Eli Zaretskii
Subject: Re: MPS: Crash while completing symbol with corfu
Date: Wed, 03 Jul 2024 18:44:03 +0300

> Date: Wed, 03 Jul 2024 18:32:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: yantar92@posteo.net, gerd.moellmann@gmail.com,
>  emacs-devel@gnu.org, eller.helmut@gmail.com
> 
> > Date: Wed, 03 Jul 2024 14:19:02 +0000
> > From: Pip Cet <pipcet@protonmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>, Gerd Möllmann <gerd.moellmann@gmail.com>, 
> > emacs-devel@gnu.org, eller.helmut@gmail.com
> > 
> > > No immediate crashes now.
> > > I will keep this session running, with your patches installed.
> > 
> > Thanks! Here's what I'm testing now, FWIW.
> > 
> > Eli, is this sufficiently isolated from the non-MPS case? We use some 
> > trivial wrapper macros which become non-trivial in the MPS case, and we 
> > always use a slightly more verbose glib function to register handlers (and, 
> > in the MPS case, a cleanup handler).
> 
> I think it's okay, but I'd prefer inline functions instead of macros
> for glib_user_data and get_glib_user_data.

Or maybe just make then UPPER-CASE named, so that it's clear they are
macros.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]