Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: emacs-devel@gnu.org,  Dmitry Gutov <dmitry@gutov.dev>
> Date: Mon, 01 Jul 2024 19:29:37 +0300
> 
> >>>> 1. M-x icomplete-mode RET
> >>>> 2. M-x rgrep RET foo RET b
> >>>>
> >>>> Error in post-command-hook (icomplete-post-command-hook):
> >>>> (wrong-type-argument number-or-marker-p nil)
> >>>
> >>> Ouch.  AFAICT the problem is in grep.el, and it's not specific to
> >>> icomplete-mode, e.g. I can reproduce it with:
> >>>
> >>>   M-: (grep-read-files "foo") RET b ?
> >>
> >> Also typing 'el TAB' after RET gives:
> >>
> >> Debugger entered--Lisp error: (error "Internal error: all doesn’t match 
> >> \\`el")
> >>   signal(error ("Internal error: all doesn’t match \\`el"))
> >>   error("Internal error: %s doesn't match %s" "all" "\\`el")
> >>   completion-pcm--merge-completions(("all" "el" "ch" "c" "cc" "cchh" "hh" 
> >> "h" "l" "am" "m" "tex" "texi" "asm") ("el"))
> >>   completion-pcm--merge-try(("el") ("all" "el" "ch" "c" "cc" "cchh" "hh" 
> >> "h" "l" "am" "m" "tex" "texi" "asm") "" "")
> >>
> >>> Does the diff below help?
> >>
> >> Thanks, after short testing I see it doesn't lose the ability to complete
> >> in both cases: a list of abbreviations and file names, while fixing
> >> the problem above, so it looks like the right thing to do.
> >
> > Great.
> >
> >>> (Note that this change has the downside that file name quoting/unquoting
> >>> is no longer applied.  Handling that with completion-table-merge might
> >>> be a bit more tricky.)
> >>
> >> Not sure how serious this limitation is.
> >
> > Yes, it's very minor, I think.
> >
> > This issue is present already in Emacs 29 with partial-completion at the
> > front of completion-styles, but in Emacs 30 it affects the default setup.
> > Should we fix this on master or on the release branch?
> 
> I don't know what Eli will decide, but this bug exists in the release branch.

Please fix on the emacs-30 release branch, and thanks.