Re: master fa4203300fd: Merge remote-tracking branch 'origin/feature/which-key-in-core'

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 19 Jun 2024 14:01:07 +0200
> 
> >>>>> On Wed, 19 Jun 2024 10:49:41 +0200, Robert Pluim <rpluim@gmail.com> 
> >>>>> said:
> 
> >>>>> On Wed, 19 Jun 2024 07:42:16 +0000, Philip Kaludercic 
> >>>>> <philipk@posteo.net> said:
>     Philip> Robert Pluim <rpluim@gmail.com> writes:
>     >>>>>>>> On Tue, 18 Jun 2024 15:46:35 -0400 (EDT), Philip Kaludercic 
> <philipk@posteo.net> said:
>     >>> 
>     Philip> +
>     Philip> ++++
>     Philip> +** New package Which-Key
>     Philip> +The 'which-key' package from GNU ELPA is now included in Emacs.  
> It
>     Philip> +implements the 'which-key-mode' that displays a table of key 
> bindings
>     Philip> +upon entering a partial key chord and waiting for a moment.
>     Philip> +
>     >>> 
>     >>> This doesnʼt appear to work for the "iso-transl" key bindings, but
>     >>> then again Iʼm not sure it should :-)
> 
>     Philip> I am not sure what bindings you have in mind specifically.  While 
> I
>     Philip> don't really have a good, global understanding of which-key, I 
> can try
>     Philip> to look into the issue (if it is one), if you give me something 
> to test.
> 
>     Robert> Iʼm thinking of stuff like 'C-x 8 * E'. Itʼs possible to argue 
> that
>     Robert> doesnʼt qualify as a 'key binding', since its entire purpose is to
>     Robert> enter a specific character, not run a command.
> 
> This patch does it, now we just need to decide if we want to do it,
> and if so, should there be a user option to enable it? Perhaps
> `function-key-map' should not be consulted.

What's the downside of doing this unconditionally?

> are we planning to turn `which-key-mode' on by default?

Not in Emacs 30, no.