emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MPS: Forwording symbols


From: Eli Zaretskii
Subject: Re: MPS: Forwording symbols
Date: Wed, 19 Jun 2024 14:22:05 +0300

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Tue, 18 Jun 2024 21:33:02 +0200
> 
> Helmut Eller <eller.helmut@gmail.com> writes:
> 
> > On Tue, Jun 18 2024, Eli Zaretskii wrote:
> >
> >>> Could this be our old friend dump_discard_mem that is too lazy to check
> >>> error codes?  What happens if you remove the call to
> >>> dump_mmap_discard_contents in pdumper_load?
> >>
> >> Then the build succeeds.
> >
> > With the patch below, dump_mmap_discard_contents calls the map->release
> > callback.  I think that was the original reason for having this
> > callback.  It also adds stricter error checking to dump_discard_mem, but
> > that function is now unused.  It's not clear to me, when it should be
> > used instead of dump_unmap_file.
> 
> Pushed.

Thanks, I've cleaned up the MS-Windows bits.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]