Re: Building master hangs generating lisp/eshell/esh-util-tests.log

[Andrea Corallo]

Alan Mackenzie <acm@muc.de> writes:

> Hello, Andrea.
>
> On Thu, Jun 13, 2024 at 04:36:04 -0400, Andrea Corallo wrote:
>> Eli Zaretskii <eliz@gnu.org> writes:
>
>> >> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
>> >> Date: Wed, 12 Jun 2024 17:54:38 +0200
>
>> >> I have retried to build master and the process hangs at
>> >> GEN      lisp/eshell/esh-util-tests.log
>
>> > I don't understand.  First, a build doesn't include running the test
>> > suite, so what do you mean by "the build process hangs at"?
>
>> > And second, running this:
>
>> >   $ make -C test lisp/eshell/esh-util-tests
>
>> > doesn't hang here.  This is with the current master branch.
>
>> I see hangs during tests on my local CI as well since about 2 3 days,
>> but unfortunatelly they are not very reproducible.  I'll try to gain
>> some more data points.
>
> I've just updated my master repo.  It built OK, and on running make
> check, two erc test files hung.  After killing them (after ~2 minutes run
> time), I got the following display on my terminal:
>
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 518
> Ran 7858 tests, 28 failed to run, 7659 results as expected, 1 unexpected,
> 198 skipped
> 2 files did not finish:
>   lisp/eshell/esh-proc-tests.log
>   lisp/eshell/esh-ext-tests.log
> 1 files contained unexpected results:
>   lisp/minibuffer-tests.log
>
> I got basically the same on running make check in one of my other repos
> which I'd just updated.  So the problem appears to be reproducible for
> me.

Right I think is reproducible for me now, I see in my CI the first
commit that makes it hang is:

3199b8584e4583a4b74263f5704a21c3431658c2
Author:     Dmitry Gutov <dmitry@gutov.dev>
AuthorDate: Tue Jun 11 21:02:57 2024 +0300
Commit:     Dmitry Gutov <dmitry@gutov.dev>
CommitDate: Tue Jun 11 21:03:19 2024 +0300

Parent:     5ecff95993d Refactor tramp-*-process-file functions
Merged:     emacs1 emacs2 emacs3 emacs4
Follows:    emacs-29.1.90 (171714)

read_and_insert_process_output: Insert before markers

* src/insdel.c (adjust_markers_for_insert): Make non-static.

* src/lisp.h: Add declaration for it.

* src/process.c (read_and_insert_process_output): Use it here.
And also call insert_1_both with BEFORE_MARKERS=t, for
compatibility with internal-default-process-filter (bug#66020).

If I apply the following:

===========

modified   src/process.c
@@ -6423,9 +6423,9 @@ read_and_insert_process_output (struct Lisp_Process *p, 
char *buf,
       specbind (Qinhibit_modification_hooks, Qt);
       decode_coding_c_string (process_coding,
                               (unsigned char *) buf, nread, curbuf);
-      adjust_markers_for_insert (PT, PT_BYTE,
-                                 PT + process_coding->produced_char,
-                                 PT_BYTE + process_coding->produced, true);
+      /* adjust_markers_for_insert (PT, PT_BYTE, */
+      /*                                PT + process_coding->produced_char, */
+      /*                                PT_BYTE + process_coding->produced, 
true); */
       unbind_to (count1, Qnil);

       read_process_output_set_last_coding_system (p, process_coding);


===========

my make check does not hang.

Ccing Dmitry.

Thanks

  Andrea