emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master bbc18031aff 1/3: Go around calling the default process filter


From: Dmitry Gutov
Subject: Re: master bbc18031aff 1/3: Go around calling the default process filter (reducing GC churn)
Date: Sun, 9 Jun 2024 05:10:34 +0300
User-agent: Mozilla Thunderbird

On 09/06/2024 04:10, Po Lu wrote:
Dmitry Gutov <dgutov@yandex.ru> writes:

+static void
+read_and_insert_process_output (struct Lisp_Process *p, char *buf,
+                                   ssize_t nread,
+                               struct coding_system *process_coding);
The identifier of a function declaration should not be broken after its
type, and its parameter list should not hold argument names, but only
their types.

+static void read_and_insert_process_output (struct Lisp_Process *p, char *buf,
+                                   ssize_t nread,
+                                   struct coding_system *process_coding)
The inverse applies here.

+  if (NILP (BVAR (XBUFFER(p->buffer), enable_multibyte_characters))
Space absent after `XBUFFER'.
I see you've made the edits. Thanks!

+  DEFVAR_BOOL ("read-process-output-fast", read_process_output_fast,
+              doc: /* Non-nil to optimize the insertion of process output.
How about `fast_read_process_output'?
Sounds good to me.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]