Re: Stipples support in MS-Windows port

[Eli Zaretskii]

> From: "Elijah G." <eg642616@gmail.com>
> Cc: luangruo@yahoo.com,  emacs-devel@gnu.org
> Date: Tue, 21 May 2024 20:06:38 -0600
> 
> For now the stipple implementation is now complete (as far as i could test),
> Now uses xbm files and stipple data.

Thanks, I have a few minor comments, and then we can install this.

> +  /* Convert X bitmap to W32 bitmap */
                                      ^
Style: C comments should end in a period and 2 spaces before "*/".

> +  dpyinfo->bitmaps[id - 1].height = width;
> +  dpyinfo->bitmaps[id - 1].width = height;
> +  dpyinfo->bitmaps[id - 1].stipple = bitmap;
> +  dpyinfo->bitmaps[id - 1].file = xlispstrdup (file);
> +  printf("%s\n", dpyinfo->bitmaps[id - 1].file);
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This printf should probably be removed or commented out.

> +static void
> +w32_fill_stipple_pattern (HDC hdc, struct glyph_string *s, Emacs_GC *gc,
> +                       int x, int y, unsigned int width, unsigned int height)
> +{
> +  /* BUG: stipple bitmap has the inverted colors, inverting
> +     those 2 functions color must fix this. */

Can we fix this before installing, please?  If there are problems with
inverting the colors that you are unsure how to fix, please describe
those problems in detail, so that others could provide advice or code.

Finally, this change needs a NEWS entry, in the "Changes in Emacs 30.1
on Non-Free Operating Systems" section.

> I would like if someone else can test it for see if there are any
> issues.

Please suggest how to test this.

Thanks.