Re: treesitter local parser: huge slowdown and memory usage in a long file

[Dmitry Gutov]

Hi Yuan,

Sorry if I'm being too pedantic here.

On 20/04/2024 05:18, Yuan Fu wrote:

> I believe I’ve found a good way to solve this problem. I pushed the changes to 
> master.
>
> Basically I added a function treesit-parser-changed-ranges that can directly 
> return the change ranges from last reparse. This means we don’t need to use 
> notifiers to get those change ranges anymore. Then in treesit-pre-redisplay, we 
> reparse the primary parser and get the changed ranges from it.
>
> Once we have the changed ranges, we update other non-primary parser’s ranges, 
> but only within the changed ranges. Originally we were updating those parser’s 
> ranges on the whole buffer, which led to the slowdown. Then we had to use some 
> workaround to solve this. Now the workaround isn’t needed anymore.

The essence of the change (querying fewer ranges) looks good.

I'm a bit uneasy about the new function and how it's supposed to be 
used. treesit-parser-changed-ranges returns the ranges changes during 
the last reparse. That seems to imply that all of its callers must have 
the up-to-date information about the state of the buffer before that 
reparse, and thus basically follow the parser's updates through some 
mechanism. The implementation also saves some information during every 
reparse, whether somebody is going to call treesit-parser-changed-ranges 
or not.

To take our new code as an example, the only client of 
treesit-parser-changed-ranges now is treesit--pre-redisplay, which is 
called from syntax-propertize-extend-region-functions and 
pre-redisplay-functions.

Is it possible that there would occur multiple changes and reparses 
between some firings of the above hooks? For example, some new feature 
might go over the buffer's text with an automated multi-step 
transformation, calling the parser (but not syntax-ppss) on each step.
In such a scenario it seems treesit--pre-redisplay might miss 
intermediate range updates. Would that be okay?