Re: MPS: face-cache

[Gerd Möllmann]

Helmut Eller <eller.helmut@gmail.com> writes:

>> I take that back. The reference to key in struct composition is of
>> course a separate reference from what's in the hash table, so it should
>> either be traced, and be in an ambiguous root so that it can't move.
>
> If it wasn't clear before, the composition stuff didn't trigger any test
> case to fail.  I know, because I tried the change below.
>
> I general, how do we deal with such cases where one could fix something
> "preventively" because it could potentially cause problems later or do
> we do let it sit there until an actual test case shows up?

I can't give a good answer to that.

My personal approach is sometimes that in areas which I'm almost sure to
never remember existing, I try to get that out of the way, so that I
don't have to remember. Or I do that "correctly" because I think it's
very likely to fall on my feet soon. Other times, I prioritize making
progress fast, and I don't give a sh*t. And so on.

But I'm fine with both approaches. A FIXME suffices.