[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8bee4060ea4 2/2: Add peg.el as a built-in library
From: |
Eli Zaretskii |
Subject: |
Re: master 8bee4060ea4 2/2: Add peg.el as a built-in library |
Date: |
Tue, 16 Apr 2024 15:31:06 +0300 |
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> Date: Mon, 15 Apr 2024 20:18:56 -0700
>
>
> On 04/14/24 07:58 AM, Eli Zaretskii wrote:
> >> From: Stefan Monnier <monnier@iro.umontreal.ca>
> >> Cc: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-devel@gnu.org
> >> Date: Sat, 13 Apr 2024 15:36:14 -0400
> >>
> >> > Ping! Eric, any progress with this?
> >>
> >> I fixed the test failures.
> >
> > Thanks.
> >
> > Eric, this leaves the documentation-related comments in my message
> > from 2 weeks ago; could you please take care of those?
>
> Done! Thank you for the push, and thanks to Stefan for fixing the tests.
>
> I hope the docs read a bit better now -- I've also removed the mention
> that `peg-parse' could also accept a single list of PEXS, as I don't
> think it can any more (and I don't think it needs to be *so* flexible as
> all that).
Thanks, but it looks like you made some editing mistake, which deleted
too much of the text, so the commit was reverted. Please take a look
and fix as needed; I tried to figure out what you wanted to do, but
couldn't, presumably because too much of the text was inadvertently
lost when you installed the changes.