emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Faces for strong, emph and friends in Info?


From: Eli Zaretskii
Subject: Re: Faces for strong, emph and friends in Info?
Date: Mon, 08 Apr 2024 21:27:43 +0300

> From: Robert Pluim <rpluim@gmail.com>
> Cc: "T.V Raman" <raman@google.com>,  emacs-devel@gnu.org
> Date: Mon, 08 Apr 2024 18:57:10 +0200
> 
>     Eli> I think it's just that no one has written the code to show *foo* and
>     Eli> _foo_ as italics and bold (and hide the _ and * characters).  Of
>     Eli> course, this will cause some lines be shorter or longer than they are
>     Eli> supposed to be, but maybe this is a worthwhile price to pay.
> 
>     Eli> Patches welcome.
> 
> How robust do you want this to be?

As robust as possible, of course.

> +(defface Info-strong
> +  '((t :inherit bold))
> +  "Face used for *strong* elements."
> +  :version "30.1")

We need fallback for terminals that don't support bold.  Some
stand-out color, perhaps?

Also, the doc string should mention Info mode.

> +      (while (re-search-forward "\\([*_]\\)\\([^*_\n]+\\)\\([*_]\\)" nil t)

This is too fragile, I think.  It matches stuff like "*Note foo_",
which can happen in cross-references, for example.  Also, what if
@emph or @strong spans a newline?

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]