Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Arash Esbati]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: master
> commit 60c9702972f3cef9e6dbbce5eaad8cc90ea7f8e8
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/help.el (help--analyze-key): Use `help-fns-function-name`
> ---
>  lisp/help.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/help.el b/lisp/help.el
> index 4171d0c57c7..bafe6032942 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -926,7 +926,9 @@ in the selected window."
>       (let ((key-desc (help-key-description key untranslated)))
>         (if (help--binding-undefined-p defn)
>             (format "%s%s is undefined" key-desc mouse-msg)
> -         (format "%s%s runs the command %S" key-desc mouse-msg defn)))
> +         (format "%s%s runs the command %s" key-desc mouse-msg
> +                 (if (symbolp defn) (prin1-to-string defn)
> +                   (help-fns-function-name defn)))))
>       defn event mouse-msg)))
>  
>  (defun help--filter-info-list (info-list i)

I think this change now produces:

  In end of data:
  help.el:931:21: Warning: the function ‘help-fns-function-name’ is not
  known to be defined.

This is with Emacs 30 (87be53846b) on macOS.

Best, Arash