[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of pass
From: |
Eli Zaretskii |
Subject: |
Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords |
Date: |
Fri, 15 Mar 2024 17:11:43 +0200 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
> Date: Fri, 15 Mar 2024 09:29:18 -0400
>
> > The changes in the above commit cause the following warning when
> > compiling simple.el:
> >
> > In read-passwd-toggle-visibility:
> > simple.el:10880:18: Warning: reference to free variable `icon-preference'
>
> Does the patch below fix the problem?
> [ I remember seeing the warning a few days ago, but can't reproduce it
> right now. ]
No, it makes things worse:
In read-passwd-mode:
simple.el:10907:16: Warning: reference to free variable
`read-passwd--show-password-icon'
simple.el:10912:12: Warning: reference to free variable `mode-line-faces'
simple.el:10915:4: Error: `define-icon' defined after use in (define-icon
read-passwd--hide-password-icon nil '((image "conceal.svg" "conceal.pbm"
:height (0.8 . em)) (symbol " ") (text "<\\>")) "Mode line icon to hide a
visible password." :group mode-line-faces :version "30.1" :help-echo "mouse-1:
Toggle password visibility") (missing `require' of a library file?)
simple.el:10915:16: Warning: reference to free variable
`read-passwd--hide-password-icon'
In end of data:
simple.el:10907:4: Warning: the function `define-icon' might not be defined
at runtime.
simple.el:10883:19: Warning: the function `icon-string' might not be defined
at runtime.
Makefile:289: recipe for target `../lisp/simple.elc' failed
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Eli Zaretskii, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Michael Albinus, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Eli Zaretskii, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Andreas Schwab, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Michael Albinus, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Andreas Schwab, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Eli Zaretskii, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Michael Albinus, 2024/03/15
- Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Stefan Monnier, 2024/03/15
Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords, Stefan Monnier, 2024/03/15