emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [External] : Merging bookmark+ features into Emacs itself


From: Drew Adams
Subject: RE: [External] : Merging bookmark+ features into Emacs itself
Date: Sat, 16 Dec 2023 23:07:19 +0000

> >> you should start working on merging
> >> bookmark+.el features into Emacs itself.
> >
> > Tried that.
> 
> Where can I find those attempts?  Why did your attempts fail?

I meant that I submitted the patches for the
fix.  I already referenced the mail that has
those patches:

https://lists.gnu.org/archive/html/emacs-devel/2022-08/msg00500.html

> Are you willing to try again?

I won't be merging anything, myself.  If
someone wants to apply the patches, and has
questions, I'll try to find the time to
answer them.  If you're actually interested
then I suggest you start with that message
and read the full (short) thread.

FWIW, for the case at hand I prefer the use
of a defvar to the alternative of depending
on a closure variable.  That gives Bookmark+
backward compatibility (support for old
Emacs versions), and it's more flexible: you
can bind the variable anywhere to affect the
code the way you want (a plus and a potential
minus, of course).

But if, as Karl expressed, vanilla Emacs
prefers to use a closure variable instead,
feel free to do so.  In that case, I'll just
have to keep the Bookmark+ version of (at
least some of) the fix code, even if the fix
is added to Emacs.

If changes are made to Emacs that mess with
what Bookmark+ does, then I'll have to work
around those.  And I don't have much time
for that.  Without Emacs getting fixed for
this I don't have to worry about that.  IMO
it makes sense for Emacs to be fixed for
this, but I'm wary of what I might have to
do afterward to mitigate the damage.

Maybe not the response you were looking for,
but hopefully it's clear at least.  I hope
the problem and the fix are also clear; I
think they should be.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]