emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regression test `cl-print-tests-ellipsis-string' fails after latest


From: Alan Mackenzie
Subject: Re: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
Date: Sat, 30 Sep 2023 14:36:53 +0000

Hello, Jens.

On Sat, Sep 30, 2023 at 11:20:04 +0200, Jens Schmidt wrote:
> Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
> introduced a regression.  The following fixes it:


> diff --git a/test/lisp/emacs-lisp/cl-print-tests.el 
> b/test/lisp/emacs-lisp/cl-print-tests.el
> index 3073a42e39d..3aac161b344 100644
> --- a/test/lisp/emacs-lisp/cl-print-tests.el
> +++ b/test/lisp/emacs-lisp/cl-print-tests.el
> @@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
>  (ert-deftest cl-print-tests-ellipsis-string ()
>    "Ellipsis expansion works in strings."
> -  (let ((print-length 4)
> +  (let ((cl-print-string-length 4)
> +        (print-length 4)
>          (print-level 3))
>      (cl-print-tests-check-ellipsis-expansion
>       "abcdefg" "\"abcd...\"" "efg")


> But the fact that one has to bind `cl-print-string-length' *and*
> `print-length' could indicate that the commit probably is not
> "complete" yet.  In the sense that more occurrences of `print-length'
> need to be modified in cl-print.el.

I simply forgot to commit the change to cl-print-tests.el, sorry.  I've
committed them now, so the tests should now run success-free again.

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]