emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] externals/greader 2ac46a52d4: greader-reading-mode: disabling


From: Stefan Monnier
Subject: Re: [elpa] externals/greader 2ac46a52d4: greader-reading-mode: disabling `view-mode' when we are active.
Date: Thu, 21 Sep 2023 09:29:18 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

>     This solution, I hope temporary, is necessary because some
>     keys in `greader-reading-mode' and `view-mode' collide, and
>     `view-mode' is loaded before greader.

Hmm... if `view-mode` is loaded first, its in `minor-mode-map-alist`
should come afterwards and so should have lower precedence, no?

>     I don't like this solution, it seems somehow inelegant,
>     but for now it's the only one that comes to mind.

There's indeed a lack of control about relative ordering in (minor)
modes in `minor-mode-map-alist` which occasionally bites us.

You might be able to solve it with:

- (require 'view) to make sure the other entry is there so you can
  change its place if needed.
- Manually rearrange the entries right after `define-minor-mode` at the
  top-level of your file (i.e. when your file is loaded rather than when
  your minor mode is activated).

Another option is to use `minor-mode-overriding-map-alist` (where you'd
put a slightly different modified for `view-mode`), but that
tends to be more invasive.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]