|
From: | Hugo Thunnissen |
Subject: | Re: [ELPA] New Package: phpinspect.el |
Date: | Tue, 15 Aug 2023 19:45:38 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 8/12/23 06:56, Stefan Monnier wrote:
I would like to propose my package, phpinspect.el, to be added to GNU Elpa.Done. AFAICT the code has currently some significant problems in terms of dependencies which make its compilation fail because variables are used by macros during compilation when the var has not yet been defined, or macros are used before they're defined, etc... The patch below seems to make the compilation go through (and fixes various warnings), but there are a lot of compilation warnings left which you might want to check. It also includes a few FIXMEs. Stefan
And here I was thinking that I had fixed all of the byte compilation problems.. Turns out it was only working because I byte compiled everything within the same emacs session. I made some changes and think things should be in order now. At least, the following shell script doesn't seem to result in any errors:
for file in ./*.el; docask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile "$file" || break
doneI see some warnings in your log that concern files in the "benchmark" and "test" directories. These files are not required for the package to function. Can these be excluded from the ELPA build somehow? I have seen some projects use a "lisp" directory for their source code, is that the recommended approach for this?
Thanks, - Hugo
[Prev in Thread] | Current Thread | [Next in Thread] |