[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New unwind-protect byte-compiler warning
From: |
Michael Albinus |
Subject: |
Re: New unwind-protect byte-compiler warning |
Date: |
Sun, 09 Apr 2023 16:20:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
Hi Mattias,
> Also thanks to Michael who fixed a few tramp-related warnings. Michael,
> here's a bonus for you uncovered by an experimental compiler change (that I
> didn't end up applying):
>
>> (defun tramp-sshfs-handle-insert-file-contents
>> (filename &optional visit beg end replace)
>> "Like `insert-file-contents' for Tramp files."
>> (setq filename (expand-file-name filename))
>> (let (signal-hook-function result)
>> (unwind-protect
>> (setq result
>> (insert-file-contents
>> (tramp-fuse-local-file-name filename) visit beg end replace))
>> (when visit (setq buffer-file-name filename))
>> (cons filename (cdr result)))))
>
> The last unwind form seems to expect its value to be used, but it is really
> discarded. Perhaps it's just a misplaced bracket?
Yes, that's an error, uncovered yet. Thanks!
I've fixed this in master.
Best regards, Michael.