emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411


From: Stefan Monnier
Subject: Re: [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411)
Date: Fri, 10 Mar 2023 14:40:37 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

> @@ -1636,7 +1636,7 @@ This command is a replacement for built-in 
> `kmacro-end-macro'."
>    (interactive (list (help--read-key-sequence)))
>    (if (= 1 (length key-list))
>        (let* ((key (format-kbd-macro (cdar key-list)))
> -             (cmd (key-binding (cdar key-list))))
> +             (cmd (key-binding key)))

Hmm... that doesn't look right: `format-kbd-macro` is like
`key-description`, i.e. it returns a human-readable version of a key
sequence.  That is (more or less) the format understood by `kbd` (and
`key-parse`) but is not the format accepted by `key-binding`, which
expects an actual vector of events (which can degenerate to a string if
the events are simple enough).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]