Re: emacs-29 56cd810b9d1: Don’t signal warning when loading go-ts-mode.el without grammar

[Eli Zaretskii]

> branch: emacs-29
> commit 56cd810b9d1a4d537bee5a2fd954d6e0d346631a
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
> 
>     Don’t signal warning when loading go-ts-mode.el without grammar
>     
>     * lisp/progmodes/go-ts-mode.el: Add a QUIET flag to the call of
>     treesit-ready-p, so that it doesn't signal a warning if
>     go-mod (tree-sitter grammar) is not available.
> ---
>  lisp/progmodes/go-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el
> index e8f93d14744..6043c86ac93 100644
> --- a/lisp/progmodes/go-ts-mode.el
> +++ b/lisp/progmodes/go-ts-mode.el
> @@ -393,7 +393,7 @@ what the parent of the node would be if it were a node."
>  
>      (treesit-major-mode-setup)))
>  
> -(if (treesit-ready-p 'gomod)
> +(if (treesit-ready-p 'gomod t)
>      (add-to-list 'auto-mode-alist '("/go\\.mod\\'" . go-mod-ts-mode)))
>  
>  (provide 'go-ts-mode)

Yuan, why was this change made?  The fact that loading go-ts-mode.el
without a grammar library causes a warning is the intended behavior:
users who don't have tree-sitter setup for Go shouldn't load this
mode, and if they do, they should know it failed, and why.  The above
change makes it fail silently, which is not a Good Thing.

What was the problem you were trying to solve?

The subsequent change, viz.:

> branch: emacs-29
> commit 59365f928565f1be551b1697b9246b00cb87a9b7
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
> 
>     * lisp/progmodes/go-ts-mode.el: Use treesit-language-available-p.
>     
>     treesit-ready-p does more checks than language grammar availability.
> ---
>  lisp/progmodes/go-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el
> index 6043c86ac93..fbe085a2c6c 100644
> --- a/lisp/progmodes/go-ts-mode.el
> +++ b/lisp/progmodes/go-ts-mode.el
> @@ -393,7 +393,7 @@ what the parent of the node would be if it were a node."
>  
>      (treesit-major-mode-setup)))
>  
> -(if (treesit-ready-p 'gomod t)
> +(if (treesit-language-available-p 'gomod)
>      (add-to-list 'auto-mode-alist '("/go\\.mod\\'" . go-mod-ts-mode)))
>  
>  (provide 'go-ts-mode)

made this even worse: now we have a byte-compilation warning in a
build without tree-sitter, and this code will signal a generic error
(whose text is not very helpful to users) if the file is loaded in a
build without tree-sitter.  This is all against the intended behavior
of these modes.

Again, what problem were you trying to fix with that change?